Change Filter Shallow Copies to Deep Copies#175
Merged
pearce8 merged 2 commits intollnl:developfrom Jun 17, 2024
Merged
Conversation
michaelmckinsey1
added
area-thicket
ilumsden
added
status-approved
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
@ilumsden made a good catch in #173, that filter copies should be deep. This PR changes
filter_metadataandfilter_statsshallow copies to be deep copies. This is because we expect the returned Thicket from a filter to be a separate Thicket object.Example of changing the filtered Thicket:
Shallow Copy - both objects change
Deep Copy - only
thchangesFor the sake of a unit test it is sufficient to check that a given filtered Thicket component
is notthe same object as the component in the original Thicket.